xichen01 commented on PR #5791: URL: https://github.com/apache/ozone/pull/5791#issuecomment-1935735705
> > I understand, but although the code seems to have changed a lot, most of the changes were actually made to pass parameters, so it may not be very easy to split, but if you think it's necessary, I'll give it a try. > > I tried to review this but not able to reason about the changes. In particular, I like to understand why it needs the new class `BlockOutputStreamResourceProvider` and also the synchronization change. > > If the changes are just some simply, mechanical changes, it is not hard to review even the change size is large. However, it is hard to review when some complicated changes (e.g. synchronization) is mixed in a lot of simple changes. OK, thank for you explain, I will try to split this into two JIRAs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
