Galsza commented on code in PR #6226:
URL: https://github.com/apache/ozone/pull/6226#discussion_r1492243276
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotUtils.java:
##########
Review Comment:
Please write a test case where we assert for the new functionality. (New
file is in a different partition than the old file)
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotUtils.java:
##########
@@ -137,13 +144,28 @@ public static void createHardLinks(Path dbPath) throws
IOException {
}
}
+ private static boolean isSamePartition(Path fromPathParent, Path
toPathParent) throws IOException {
+ try {
+ if (fromPathParent == null || toPathParent == null) {
Review Comment:
This check should be at the start of the method outside of this try catch
block for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
