hemantk-12 commented on PR #6226: URL: https://github.com/apache/ozone/pull/6226#issuecomment-1962203973
@errose28 regarding point#2 > 2. Deprecate configs for setting snapshot install location to a different directory and put it directly in the OM DB directory. I don't see an advantage to doing the initial download in a different place. @aswinshakil, @swamirishi and I had a discussion about it and we didn't see any problem if candidate dir just resides inside `ozone.om.db.dirs`. I looked into code and config for the snapshot dir is [ozone.om.ratis.snapshot.dir](https://github.com/apache/ozone/blob/5715aee57168698a78075aa12f01c0d57b5b1f7d/hadoop-hdds/common/src/main/resources/ozone-default.xml#L2146) and if it is not set, it falls back to `ozone.metadata.dirs`. There is no call out or recommendation to have `ozone.om.ratis.snapshot.dir` or `ozone.metadata.dirs` in the same partition as `ozone.om.db.dirs`. [Original PR#703 discussion](https://github.com/apache/hadoop/pull/703#discussion_r290413302). If we can get to an agreement that `ozone.om.ratis.snapshot.dir` should be in the same partition as `ozone.om.db.dirs`. I think we should add it to release notes and make it a general recommendation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
