errose28 commented on code in PR #6241:
URL: https://github.com/apache/ozone/pull/6241#discussion_r1498224605
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java:
##########
@@ -330,16 +330,16 @@ public void setMoveTimeout(Duration duration) {
this.moveTimeout = duration.toMillis();
}
- public void setMoveTimeout(long millis) {
- this.moveTimeout = millis;
+ public void setMoveTimeout(long minutes) {
Review Comment:
Most places in the code that use long for time intervals are referring to
millis. I think changing this parameter may be confusing.
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java:
##########
@@ -74,13 +74,54 @@ public class ContainerBalancerStartSubcommand extends
ScmSubcommand {
"(for example, '26' for 26GB).")
private Optional<Long> maxSizeLeavingSourceInGB;
+ @Option(names = {"-b", "--balancing-iteration-interval"},
+ description = "The interval period between each iteration of Container
Balancer." +
+ "(for example, '70' for 70m).")
+ private Optional<Long> balancingInterval;
+
+ @Option(names = {"-mt", "--move-timeout"},
Review Comment:
I think we are trying to move away from single dash short options like
`-mrt`. Since these are advanced configurations and the abbreviations are not
very intuitive, I think we would be ok to only provide long options for these
configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
