sumitagrawl commented on code in PR #6241:
URL: https://github.com/apache/ozone/pull/6241#discussion_r1505505507
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java:
##########
@@ -74,13 +74,54 @@ public class ContainerBalancerStartSubcommand extends
ScmSubcommand {
"(for example, '26' for 26GB).")
private Optional<Long> maxSizeLeavingSourceInGB;
+ @Option(names = {"-b", "--balancing-iteration-interval"},
+ description = "The interval period between each iteration of Container
Balancer." +
+ "(for example, '70' for 70m).")
Review Comment:
Need description to provide unit type for every parameter with minimum
supported value,
The interval period in minutes between each iteration of Container Balancer.
Value should be greater than '0'. Example: '70' for 70 minutes.
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java:
##########
@@ -74,13 +74,54 @@ public class ContainerBalancerStartSubcommand extends
ScmSubcommand {
"(for example, '26' for 26GB).")
private Optional<Long> maxSizeLeavingSourceInGB;
+ @Option(names = {"-b", "--balancing-iteration-interval"},
+ description = "The interval period between each iteration of Container
Balancer." +
+ "(for example, '70' for 70m).")
Review Comment:
we need provide default value for all parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
