errose28 commented on code in PR #6245:
URL: https://github.com/apache/ozone/pull/6245#discussion_r1505161743


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java:
##########
@@ -85,7 +85,7 @@ public abstract class TestOzoneManagerHA {
   /* Reduce max number of retries to speed up unit test. */
   private static final int OZONE_CLIENT_FAILOVER_MAX_ATTEMPTS = 5;
   private static final int IPC_CLIENT_CONNECT_MAX_RETRIES = 4;
-  private static final long SNAPSHOT_THRESHOLD = 50;
+  private static final long SNAPSHOT_THRESHOLD = 1;

Review Comment:
   I think desired result is that only the new snapshot test in 
`TestOzoneManagerPrepare` has a snapshot threshold of 1, and the rest of the 
tests for `TestOzoneManagerPrepare` and  `TestOzoneManagerHA` subclasses remain 
unchanged. Doing that with the current `TestOzoneManagerHA` setup is difficult 
because it is using a static method to set the configuration, so some 
refactoring may be required there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to