errose28 commented on code in PR #6245:
URL: https://github.com/apache/ozone/pull/6245#discussion_r1506758128
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java:
##########
@@ -85,7 +85,7 @@ public abstract class TestOzoneManagerHA {
/* Reduce max number of retries to speed up unit test. */
private static final int OZONE_CLIENT_FAILOVER_MAX_ATTEMPTS = 5;
private static final int IPC_CLIENT_CONNECT_MAX_RETRIES = 4;
- private static final long SNAPSHOT_THRESHOLD = 50;
+ private static final long SNAPSHOT_THRESHOLD = 1;
Review Comment:
> the transaction index increases due to which we may not be able to produce
the current scenario i.e, SNAPSHOT_THRESHOLD = 1.
> If we do so, the transaction index will still increase due to the setup()
function in TestOzoneManagerPrepare!
I think there may be some misunderstanding about the snapshot threshold?
SNAPSHOT_THRESHOLD=1 means the OM will take a snapshot on every new request,
not that it will only take a snapshot on index 1. The transaction index can be
any number at any time during the test, and by setting this config to 1 we know
that transaction will have a snapshot taken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
