ivandika3 commented on code in PR #6378:
URL: https://github.com/apache/ozone/pull/6378#discussion_r1526003861
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java:
##########
@@ -984,7 +983,7 @@ private Builder(ConfigurationSource conf, ClientProtocol
proxy) {
}
public Builder setMetadata(Map<String, String> metadata) {
- this.metadata = metadata;
+ addAllMetadata(metadata);
Review Comment:
Nit: Should not affect current usage, but the semantic seems to be changed
changed from "replacing" to "adding". Might need to clear the metadata before
adding it or can change the method name to `addAllMetadata` (but `OzoneBucket`
is client-facing class so might not be a good idea).
I'm OK if you decide not to change it at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
