szetszwo commented on code in PR #6378:
URL: https://github.com/apache/ozone/pull/6378#discussion_r1540327853
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java:
##########
@@ -984,7 +983,7 @@ private Builder(ConfigurationSource conf, ClientProtocol
proxy) {
}
public Builder setMetadata(Map<String, String> metadata) {
- this.metadata = metadata;
+ super.setMetadata(metadata);
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -469,24 +456,22 @@ public Builder setModificationTime(long modifiedOn) {
}
public Builder setObjectID(long obId) {
- this.objectID = obId;
+ super.setObjectID(obId);
return this;
}
public Builder setUpdateID(long id) {
- this.updateID = id;
+ super.setUpdateID(id);
return this;
}
public Builder addMetadata(String key, String value) {
- metadata.put(key, value);
+ super.addMetadata(key, value);
return this;
}
public Builder addAllMetadata(Map<String, String> additionalMetadata) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -469,24 +456,22 @@ public Builder setModificationTime(long modifiedOn) {
}
public Builder setObjectID(long obId) {
- this.objectID = obId;
+ super.setObjectID(obId);
return this;
}
public Builder setUpdateID(long id) {
- this.updateID = id;
+ super.setUpdateID(id);
return this;
}
public Builder addMetadata(String key, String value) {
- metadata.put(key, value);
+ super.addMetadata(key, value);
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -469,24 +456,22 @@ public Builder setModificationTime(long modifiedOn) {
}
public Builder setObjectID(long obId) {
- this.objectID = obId;
+ super.setObjectID(obId);
return this;
}
public Builder setUpdateID(long id) {
- this.updateID = id;
+ super.setUpdateID(id);
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -492,12 +487,12 @@ public Builder setReplicationConfig(ReplicationConfig
replConfig) {
}
public Builder addMetadata(String key, String value) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java:
##########
@@ -306,39 +320,24 @@ public static class Builder {
private long quotaInBytes;
private long quotaInNamespace;
private long usedNamespace;
- private Map<String, String> metadata;
private List<OzoneAcl> acls;
- private long objectID;
- private long updateID;
private long refCount;
- /**
- * Sets the Object ID for this Object.
- * Object ID are unique and immutable identifier for each object in the
- * System.
- * @param id - long
- */
public Builder setObjectID(long id) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java:
##########
@@ -384,14 +383,12 @@ public Builder setUsedNamespace(long namespaceUsage) {
}
public Builder addMetadata(String key, String value) {
- metadata.put(key, value); // overwrite if present.
+ super.addMetadata(key, value);
return this;
}
public Builder addAllMetadata(Map<String, String> additionalMetaData) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java:
##########
@@ -469,24 +456,22 @@ public Builder setModificationTime(long modifiedOn) {
}
public Builder setObjectID(long obId) {
- this.objectID = obId;
+ super.setObjectID(obId);
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -521,12 +516,12 @@ public Builder addAcl(OzoneAcl ozoneAcl) {
}
public Builder setObjectID(long obId) {
- this.objectID = obId;
+ super.setObjectID(obId);
return this;
}
public Builder setUpdateID(long id) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneVolume.java:
##########
@@ -483,7 +482,7 @@ public Builder setRefCount(long refCount) {
}
public Builder setMetadata(Map<String, String> metadata) {
- this.metadata = metadata;
+ super.setMetadata(metadata);
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketArgs.java:
##########
@@ -259,7 +257,7 @@ public Builder
setBucketEncryptionKey(BucketEncryptionKeyInfo info) {
}
public Builder addAllMetadata(Map<String, String> map) {
- metadata.putAll(map);
+ super.addAllMetadata(map);
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDirectoryInfo.java:
##########
@@ -77,38 +73,31 @@ public static OmDirectoryInfo.Builder newBuilder() {
/**
* Builder for Directory Info.
*/
- public static class Builder {
- private long parentObjectID; // pointer to parent directory
-
- private long objectID;
- private long updateID;
-
+ public static class Builder extends WithParentObjectId.Builder {
private String name;
private long creationTime;
private long modificationTime;
private final List<OzoneAcl> acls;
- private final Map<String, String> metadata;
public Builder() {
//Default values
this.acls = new LinkedList<>();
- this.metadata = new HashMap<>();
}
public Builder setParentObjectID(long parentObjectId) {
- this.parentObjectID = parentObjectId;
+ super.setParentObjectID(parentObjectId);
return this;
}
public Builder setObjectID(long objectId) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDirectoryInfo.java:
##########
@@ -77,38 +73,31 @@ public static OmDirectoryInfo.Builder newBuilder() {
/**
* Builder for Directory Info.
*/
- public static class Builder {
- private long parentObjectID; // pointer to parent directory
-
- private long objectID;
- private long updateID;
-
+ public static class Builder extends WithParentObjectId.Builder {
private String name;
private long creationTime;
private long modificationTime;
private final List<OzoneAcl> acls;
- private final Map<String, String> metadata;
public Builder() {
//Default values
this.acls = new LinkedList<>();
- this.metadata = new HashMap<>();
}
public Builder setParentObjectID(long parentObjectId) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDirectoryInfo.java:
##########
@@ -77,38 +73,31 @@ public static OmDirectoryInfo.Builder newBuilder() {
/**
* Builder for Directory Info.
*/
- public static class Builder {
- private long parentObjectID; // pointer to parent directory
-
- private long objectID;
- private long updateID;
-
+ public static class Builder extends WithParentObjectId.Builder {
private String name;
private long creationTime;
private long modificationTime;
private final List<OzoneAcl> acls;
- private final Map<String, String> metadata;
public Builder() {
//Default values
this.acls = new LinkedList<>();
- this.metadata = new HashMap<>();
}
public Builder setParentObjectID(long parentObjectId) {
- this.parentObjectID = parentObjectId;
+ super.setParentObjectID(parentObjectId);
return this;
}
public Builder setObjectID(long objectId) {
- this.objectID = objectId;
+ super.setObjectID(objectId);
return this;
}
public Builder setUpdateID(long updateId) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDirectoryInfo.java:
##########
@@ -142,14 +131,12 @@ public Builder addAcl(OzoneAcl ozoneAcl) {
}
public Builder addMetadata(String key, String value) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDirectoryInfo.java:
##########
@@ -142,14 +131,12 @@ public Builder addAcl(OzoneAcl ozoneAcl) {
}
public Builder addMetadata(String key, String value) {
- metadata.put(key, value);
+ super.addMetadata(key, value);
return this;
}
public Builder addAllMetadata(Map<String, String> additionalMetadata) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -492,12 +487,12 @@ public Builder setReplicationConfig(ReplicationConfig
replConfig) {
}
public Builder addMetadata(String key, String value) {
- metadata.put(key, value);
+ super.addMetadata(key, value);
return this;
}
public Builder addAllMetadata(Map<String, String> newMetadata) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -536,7 +531,7 @@ public Builder setFileName(String keyFileName) {
}
public Builder setParentObjectID(long parentID) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -521,12 +516,12 @@ public Builder addAcl(OzoneAcl ozoneAcl) {
}
public Builder setObjectID(long obId) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/helpers/OmPrefixInfo.java:
##########
@@ -125,25 +123,23 @@ public Builder setName(String n) {
}
public OmPrefixInfo.Builder addMetadata(String key, String value) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java:
##########
@@ -306,39 +320,24 @@ public static class Builder {
private long quotaInBytes;
private long quotaInNamespace;
private long usedNamespace;
- private Map<String, String> metadata;
private List<OzoneAcl> acls;
- private long objectID;
- private long updateID;
private long refCount;
- /**
- * Sets the Object ID for this Object.
- * Object ID are unique and immutable identifier for each object in the
- * System.
- * @param id - long
- */
public Builder setObjectID(long id) {
- this.objectID = id;
+ super.setObjectID(id);
return this;
}
- /**
- * Sets the update ID for this Object. Update IDs are monotonically
- * increasing values which are updated each time there is an update.
- * @param id - long
- */
public Builder setUpdateID(long id) {
Review Comment:
Add `@Override`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java:
##########
@@ -384,14 +383,12 @@ public Builder setUsedNamespace(long namespaceUsage) {
}
public Builder addMetadata(String key, String value) {
Review Comment:
Add `@Override`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
