sodonnel commented on PR #6385:
URL: https://github.com/apache/ozone/pull/6385#issuecomment-2013968721

   > I don't think a key with an open lease being hsync'ed should be eligible 
for overwrite
   
   A key being hsync'ed is "open but visible" in Ozone and hence should have a 
lease which blocks other writers.
   
   I think the "hsync / hbase" work also allows for a key to be appended - ie 
the key is closed and committed. Then a writer reopens it and appends some new 
data and commits / closes it again.
   
   While the first scenario should be blocked, I need to ensure we do the right 
thing if an append happens to a closed key that is currently being overwrriten, 
and whether that is even possible! I will ask around about that.
   
   I think you could be write that update_id is all we need as it will change 
on key append, hsync and object delete and recreate. It would be much nicer to 
only need to use 1 field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to