adoroszlai commented on code in PR #6416:
URL: https://github.com/apache/ozone/pull/6416#discussion_r1535094863


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java:
##########
@@ -753,6 +754,33 @@ public void testLinkBucketOrphan() throws Exception {
     }
   }
 
+  @Test
+  public void testListBucket() throws Exception {
+    final String hostPrefix = OZONE_OFS_URI_SCHEME + "://" + omServiceId;
+    OzoneConfiguration clientConf =
+            getClientConfForOFS(hostPrefix, cluster.getConf());
+    int pageSize = 20;
+    clientConf.setInt(OZONE_FS_LISTING_PAGE_SIZE, pageSize);

Review Comment:
   `FileSystem` may already be cached, so updated config may not be applied.  
Thus the test may pass even without the fix.
   
   ```suggestion
       clientConf.setInt(OZONE_FS_LISTING_PAGE_SIZE, pageSize);
       URI uri = FileSystem.getDefaultUri(clientConf);
       clientConf.setBoolean(String.format("fs.%s.impl.disable.cache", 
uri.getScheme()), true);
   ```
   
   (needs `import java.net.URI`, too)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to