symious commented on code in PR #6416:
URL: https://github.com/apache/ozone/pull/6416#discussion_r1535115154
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -882,9 +882,9 @@ public List<FileStatusAdapter> listStatus(String pathStr,
boolean recursive,
}
OFSPath ofsStartPath = new OFSPath(startPath, config);
if (ofsPath.isVolume()) {
- String startBucket = ofsStartPath.getBucketName();
+ String startBucketPath = ofsStartPath.getNonKeyPath();
return listStatusVolume(ofsPath.getVolumeName(),
- recursive, startBucket, numEntries, uri, workingDir, username);
+ recursive, startBucketPath, numEntries, uri, workingDir, username);
Review Comment:
Currently, all the following methods are using String as parameter, maybe we
can align to use String here or it might confuse people more?
```
listStatusBucketSnapshot(ofsPath.getVolumeName(), ofsPath.getBucketName(),
uri);
listStatusVolume(ofsPath.getVolumeName(), recursive, startBucketPath,
numEntries, uri, workingDir, username);
listStatusRoot(recursive, startPath, numEntries, uri, workingDir, username);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
