Tejaskriya commented on code in PR #6367:
URL: https://github.com/apache/ozone/pull/6367#discussion_r1538700923
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeDecommissionManager.java:
##########
@@ -56,17 +75,50 @@ public class TestNodeDecommissionManager {
private NodeDecommissionManager decom;
private StorageContainerManager scm;
private NodeManager nodeManager;
+ private ContainerManager containerManager;
private OzoneConfiguration conf;
+ @TempDir
+ private File testDir;
+ private DBStore dbStore;
+ private SCMHAManager scmhaManager;
+ private SequenceIdGenerator sequenceIdGen;
+ private ContainerReplicaPendingOps pendingOpsMock;
@BeforeEach
void setup(@TempDir File dir) throws Exception {
conf = new OzoneConfiguration();
conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, dir.getAbsolutePath());
- nodeManager = createNodeManager(conf);
- decom = new NodeDecommissionManager(conf, nodeManager,
+ scm = HddsTestUtils.getScm(conf);
+ nodeManager = scm.getScmNodeManager();
+ final OzoneConfiguration ozConf = SCMTestUtils.getConf(testDir);
+ dbStore = DBStoreBuilder.createDBStore(
+ ozConf, new SCMDBDefinition());
+ scmhaManager = SCMHAManagerStub.getInstance(true);
+ sequenceIdGen = new SequenceIdGenerator(
+ ozConf, scmhaManager, SCMDBDefinition.SEQUENCE_ID.getTable(dbStore));
+ final PipelineManager pipelineManager =
+ new MockPipelineManager(dbStore, scmhaManager, nodeManager);
+ pipelineManager.createPipeline(RatisReplicationConfig.getInstance(
+ HddsProtos.ReplicationFactor.THREE));
+ pendingOpsMock = mock(ContainerReplicaPendingOps.class);
+ containerManager = new ContainerManagerImpl(ozConf,
Review Comment:
Thanks for the review, I have used mock for these tests now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
