Tejaskriya commented on code in PR #6367:
URL: https://github.com/apache/ozone/pull/6367#discussion_r1542376836
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -368,6 +384,57 @@ public synchronized void startDecommission(DatanodeDetails
dn)
}
}
+ private synchronized boolean
checkIfDecommissionPossible(List<DatanodeDetails> dns, List<DatanodeAdminError>
errors) {
+ int minInService = -1, numDecom = dns.size();
+ int inServiceTotal =
nodeManager.getNodeCount(NodeStatus.inServiceHealthy());
+ for (DatanodeDetails dn : dns) {
+ try {
+ NodeStatus nodeStatus = getNodeStatus(dn);
+ NodeOperationalState opState = nodeStatus.getOperationalState();
+ if (opState != NodeOperationalState.IN_SERVICE) {
+ numDecom--;
+ }
+ } catch (NodeNotFoundException ex) {
+ numDecom--;
+ }
+ }
+
+ for (DatanodeDetails dn : dns) {
Review Comment:
I have added test for checking nodes not-in-service. But in case of
NodeNotFound, In the current logic, if we pass the hostname for a non-existent
DN then it is caught in `mapHostnamesToDatanodes(nodes, errors)` and the DN is
not added to the datanodeDetails list (dns) we iterate through for the checks.
Do we need to still consider this scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
