siddhantsangwan commented on code in PR #6241:
URL: https://github.com/apache/ozone/pull/6241#discussion_r1540644004
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1105,6 +1111,54 @@ public StartContainerBalancerResponseProto
startContainerBalancer(
cbc.setMaxSizeLeavingSource(msls * OzoneConsts.GB);
}
+ if (balancingInterval.isPresent()) {
+ long bi = balancingInterval.get();
+ auditMap.put("balancingInterval", String.valueOf(bi));
+ Preconditions.checkState(bi > 0,
+ "balancingInterval must be greater than zero.");
+ cbc.setBalancingInterval(bi);
+ }
+
+ if (moveTimeout.isPresent()) {
+ long mt = moveTimeout.get();
+ auditMap.put("moveTimeout", String.valueOf(mt));
+ Preconditions.checkState(mt > 0,
+ "moveTimeout must be greater than zero.");
+ cbc.setMoveTimeout(mt);
+ }
+
+ if (moveReplicationTimeout.isPresent()) {
+ long mrt = moveReplicationTimeout.get();
+ auditMap.put("moveReplicationTimeout", String.valueOf(mrt));
+ Preconditions.checkState(mrt > 0,
+ "moveTimeout must be greater than zero.");
Review Comment:
I think we can make the code simpler by just using an `IOException` instead
of an `SCMException`. In this method we're creating an exception only to catch
it later and audit the failure. The original pattern was probably to create an
exception, audit it, and then throw it back to the caller, therefore creating
an exception was required in the first place.
Here, it's sufficient to just use an IOException since we are just catching
it. Even simpler and maybe faster would be to not use exceptions at all... but
we don't need to go there in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
