sarvekshayr commented on code in PR #6241:
URL: https://github.com/apache/ozone/pull/6241#discussion_r1540743625
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1105,6 +1111,54 @@ public StartContainerBalancerResponseProto
startContainerBalancer(
cbc.setMaxSizeLeavingSource(msls * OzoneConsts.GB);
}
+ if (balancingInterval.isPresent()) {
+ long bi = balancingInterval.get();
+ auditMap.put("balancingInterval", String.valueOf(bi));
+ Preconditions.checkState(bi > 0,
+ "balancingInterval must be greater than zero.");
+ cbc.setBalancingInterval(bi);
+ }
+
+ if (moveTimeout.isPresent()) {
+ long mt = moveTimeout.get();
+ auditMap.put("moveTimeout", String.valueOf(mt));
+ Preconditions.checkState(mt > 0,
+ "moveTimeout must be greater than zero.");
+ cbc.setMoveTimeout(mt);
+ }
+
+ if (moveReplicationTimeout.isPresent()) {
+ long mrt = moveReplicationTimeout.get();
+ auditMap.put("moveReplicationTimeout", String.valueOf(mrt));
+ Preconditions.checkState(mrt > 0,
+ "moveTimeout must be greater than zero.");
Review Comment:
> I think we can make the code simpler by just using an `IOException`
instead of an `SCMException`.
I've made the required changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
