Tejaskriya commented on code in PR #6367:
URL: https://github.com/apache/ozone/pull/6367#discussion_r1546127964
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeDecommissionManager.java:
##########
@@ -369,10 +410,208 @@ public void testNodeDecommissionManagerOnBecomeLeader()
throws Exception {
assertEquals(decom.getMonitor().getTrackedNodes().size(), 3);
}
- private SCMNodeManager createNodeManager(OzoneConfiguration config)
- throws IOException, AuthenticationException {
- scm = HddsTestUtils.getScm(config);
- return (SCMNodeManager) scm.getScmNodeManager();
+ @Test
+ public void testInsufficientNodeDecommissionThrowsExceptionForRatis() throws
Review Comment:
Thank you for the review! I have added these checks in the tests. I have
addressed the other comments as well. Could you please take a look at this PR
again and approve the workflows if everything seems okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
