hemantk-12 commented on code in PR #6453:
URL: https://github.com/apache/ozone/pull/6453#discussion_r1548820892
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java:
##########
@@ -112,9 +115,16 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
omClientResponse = new OMSnapshotPurgeResponse(omResponse.build(),
snapshotDbKeys, updatedSnapInfos,
updatedPathPreviousAndGlobalSnapshots);
+
+ omMetrics.incNumSnapshotPurges();
+ LOG.info("Successfully executed snapshotPurgeRequest: {{}} along with
updating deep clean flags for " +
+ "snapshots: {} and global and previous for snapshots:{}.",
+ snapshotPurgeRequest, updatedSnapInfos.keySet(),
updatedPathPreviousAndGlobalSnapshots.keySet());
Review Comment:
Again ideally log level should be debug for this but we need the whole
information (all the snapshots get updated as part of the purge) for the
snapshot chain corruption.
Once we have confidence that all the concurrent issues are fixed for the
snapshot chain, we should change it to the debug level.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java:
##########
@@ -112,9 +115,16 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
omClientResponse = new OMSnapshotPurgeResponse(omResponse.build(),
snapshotDbKeys, updatedSnapInfos,
updatedPathPreviousAndGlobalSnapshots);
+
+ omMetrics.incNumSnapshotPurges();
+ LOG.info("Successfully executed snapshotPurgeRequest: {{}} along with
updating deep clean flags for " +
+ "snapshots: {} and global and previous for snapshots:{}.",
+ snapshotPurgeRequest, updatedSnapInfos.keySet(),
updatedPathPreviousAndGlobalSnapshots.keySet());
Review Comment:
Ideally log level should be debug for this but we need the whole information
(all the snapshots get updated as part of the purge) for the snapshot chain
corruption.
Once we have confidence that all the concurrent issues are fixed for the
snapshot chain, we should change it to the debug level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
