smengcl commented on code in PR #6453:
URL: https://github.com/apache/ozone/pull/6453#discussion_r1549002607
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/snapshot/TestOMSnapshotPurgeRequestAndResponse.java:
##########
@@ -260,6 +262,8 @@ public void testValidateAndUpdateCache() throws Exception {
for (Path checkpoint : checkpointPaths) {
assertFalse(Files.exists(checkpoint));
}
+ assertEquals(initialSnapshotPurgeCount + 1,
omMetrics.getNumSnapshotPurges());
+ assertEquals(initialSnapshotPurgeFailCount,
omMetrics.getNumSnapshotPurgeFails());
Review Comment:
If it isn't too much hassle we could add another UT to inject failure to
test the fail counter as well. :) Same for
`TestOMSnapshotSetPropertyRequestAndResponse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
