adoroszlai commented on code in PR #6458:
URL: https://github.com/apache/ozone/pull/6458#discussion_r1555460145
##########
hadoop-ozone/dev-support/checks/acceptance.sh:
##########
@@ -19,15 +19,19 @@ set -u -o pipefail
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
cd "$DIR/../../.." || exit 1
-source "${DIR}/_lib.sh"
+OZONE_ROOT=$(pwd -P)
Review Comment:
`DIR` is set to the directory of this script
(`hadoop-ozone/dev-support/checks`). This is common in all checks.
`OZONE_ROOT` is set to the repo's root dir, to which the previous `cd
$DIR/../../..` command changed. This works even if executed without git repo
(i.e. extracted from source release tarball).
##########
hadoop-ozone/dist/src/main/compose/common/s3a-test.sh:
##########
@@ -0,0 +1,41 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# shellcheck source=/dev/null
+source "$COMPOSE_DIR/../testlib.sh"
+
+start_docker_env
+
+if [[ ${SECURITY_ENABLED} == "true" ]]; then
+ execute_robot_test s3g kinit.robot
+ # TODO get secret
Review Comment:
Implemented instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
