errose28 commented on code in PR #6458:
URL: https://github.com/apache/ozone/pull/6458#discussion_r1561503784


##########
hadoop-ozone/dist/src/main/compose/test-all.sh:
##########
@@ -46,7 +46,8 @@ if [[ "${OZONE_WITH_COVERAGE}" == "true" ]]; then
   cp /tmp/jacoco-combined.exec "$SCRIPT_DIR"/result
 fi
 
-generate_report "acceptance" "${ALL_RESULT_DIR}" "${XUNIT_RESULT_DIR}"
-
+if [[ "${OZONE_ACCEPTANCE_SUITE:-}" != "s3a" ]]; then
+  generate_report "acceptance" "${ALL_RESULT_DIR}" "${XUNIT_RESULT_DIR}"

Review Comment:
   Right, my question is more generally: what is the expected way to run all 
acceptance tests locally and manually? Ideally running `test-all.sh` (or 
maybe`acceptance.sh`) should kick off all the acceptance tests locally. After 
this change, running either of these will only run the robot tests, unless the 
user knows which variables to export to their shell before running.
   
   Maybe that's ok for now and we can handle that in a follow up task, since 
there's probably not many people running all the tests this way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to