swamirishi commented on code in PR #6171:
URL: https://github.com/apache/ozone/pull/6171#discussion_r1568100595
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -587,7 +587,7 @@ void addToCompactionLogTable(CompactionLogEntry
compactionLogEntry) {
* Check if there is any in_progress tarball creation request and wait till
* all tarball creation finish, and it gets notified.
*/
- private void waitForTarballCreation() {
+ private synchronized void waitForTarballCreation() {
Review Comment:
What I didn't understand is getCheckpoint() method is not taking a
synchronized lock. So the question if waitForTarballCreation() passes.
https://github.com/apache/ozone/blob/2c0580dbb2edeb94ec263aa44fd1e22cff838dcc/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java#L248
can still run. Thus isn't there a race condition here? So while compaction is
running we still end up starting a tarballing for the checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
