hemantk-12 commented on code in PR #6171:
URL: https://github.com/apache/ozone/pull/6171#discussion_r1568195432
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -587,7 +587,7 @@ void addToCompactionLogTable(CompactionLogEntry
compactionLogEntry) {
* Check if there is any in_progress tarball creation request and wait till
* all tarball creation finish, and it gets notified.
*/
- private void waitForTarballCreation() {
+ private synchronized void waitForTarballCreation() {
Review Comment:
I think you are right if we are appending compaction log entries to a txt
file but we don't use that anymore and add entries to compactionLog
columnFamily.
I gave it more thought and I think this locking is not needed anymore
because we use RocksDB column family for compaction now. So compaction entry
will be either present in the table or not in the snapshot of the ActiveFS
depending on the order or compaction entry append and checkpoint creation.
Hence we can simply remove this locking code and just rely on RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
