raju-balpande commented on code in PR #6585:
URL: https://github.com/apache/ozone/pull/6585#discussion_r1578997148
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconAndAdminContainerCLI.java:
##########
@@ -261,7 +261,8 @@ void testNodesInDecommissionOrMaintenance(
// a new replica-copy is made to another node.
// For maintenance, there is no replica-copy in this case.
if (!isMaintenance) {
- TestHelper.waitForReplicaCount(containerIdR3, 4, cluster);
+ GenericTestUtils.waitFor(() -> TestHelper.countReplicas(containerIdR3,
cluster) == 4,
+ 200, 30000);
Review Comment:
That is why I cross checked the uses of waitForReplicaCount which I found in
TestContainerReplication, And I tried to see its flakiness..
- Worked 100% success for 10x10
https://github.com/raju-balpande/apache_ozone/actions/runs/8710014704
- Worked 99.5% success for 20x20
https://github.com/raju-balpande/apache_ozone/actions/runs/8720977974
And seems no change require for this class.
Please suggest if I shall make this change in TestHelper.waitForReplicaCount
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
