raju-balpande commented on code in PR #6585:
URL: https://github.com/apache/ozone/pull/6585#discussion_r1579252937
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconAndAdminContainerCLI.java:
##########
@@ -261,7 +261,8 @@ void testNodesInDecommissionOrMaintenance(
// a new replica-copy is made to another node.
// For maintenance, there is no replica-copy in this case.
if (!isMaintenance) {
- TestHelper.waitForReplicaCount(containerIdR3, 4, cluster);
+ GenericTestUtils.waitFor(() -> TestHelper.countReplicas(containerIdR3,
cluster) == 4,
+ 200, 30000);
Review Comment:
I agree to your point. Even though the TestContainerReplication is not
breaking now but the following two lines are indicating the condition is true
for short span which if missed will fail the test method and hence thought to
extend the change for this class as well. Hence making change in
TestHelper.waitForReplicaCount only.
<img width="783" alt="image"
src="https://github.com/apache/ozone/assets/146973984/91753787-4dfd-436b-a570-61b28af16844";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
