hemantk-12 opened a new pull request, #6659: URL: https://github.com/apache/ozone/pull/6659
## What changes were proposed in this pull request? After applying RATIS-2045, we saw lots of integration test failures as described in the HDDS-10696. It is because of how MiniOzoneHACluster is set up. It doesn't set value for config `ozone.om.db.dirs` which OMDBCheckpointServlet is trying to access [here](https://github.com/apache/ozone/blob/ff78dc83a7640bf1dbed409bc6e79b3a0f231483/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java#L320). So when `ozone.om.db.dirs` is not set, [ServerUtils#getDBPath](https://github.com/apache/ozone/blob/ff78dc83a7640bf1dbed409bc6e79b3a0f231483/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/server/ServerUtils.java#L292) returns `ozone.metadata.dirs`. Because of that **snapshotDir path**: is getting evaluated to`/Users/iamgroot/ozone-ws/ozone/hadoop-ozone/integration-test/target/test-dir/MiniOzoneClusterImpl-e919072d-914a-4de6-9bfc-5b610697b58a/ozone-meta/db.snapshots`, and the test is trying to access that doesn't exist causing `NoSuchFileException`. In the actual **snapshotDir path** is `/Users/iamgroot/ozone-ws/ozone/hadoop-ozone/integration-test/target/test-dir/MiniOzoneClusterImpl-1146c9db-bf52-4c4b-94c9-131053141484/omNode-1/db.snapshots` which is inside the ozone data directory. To fix the issue, I changed the way we are trying to get the `snapshotDir`. So rather than creating one, it will get from RDBStore after the change which should exist by default after snapshot feature. Also remote `Flaky` annotation from the test because jira: HDDS-7880 has been resolved after RATIS-1960. ## What is the link to the Apache JIRA HDDS-10696 ## How was this patch tested? Applied the [patch](https://github.com/hemantk-12/ozone/commit/900ac073c49e8a05c8afe1feae98498c76955906) on top of [the changes where we saw the failure](https://github.com/duongkame/ozone/commit/826340e8cf35e678380e893b508ec94fff3416bf). And verify by running the full [workflow](https://github.com/hemantk-12/ozone/actions/runs/8996903031) and [flaky-test-workflow](https://github.com/hemantk-12/ozone/actions/runs/8996914220) 5x5 time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
