hemantk-12 commented on code in PR #6659:
URL: https://github.com/apache/ozone/pull/6659#discussion_r1594800823


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java:
##########
@@ -317,8 +318,7 @@ private boolean getFilesForArchive(DBCheckpoint checkpoint,
 
     // Get the snapshot files.
     Set<Path> snapshotPaths = waitForSnapshotDirs(checkpoint);
-    Path snapshotDir = Paths.get(OMStorage.getOmDbDir(getConf()).toString(),
-        OM_SNAPSHOT_DIR);
+    Path snapshotDir = Paths.get(getSnapshotsParentDir()).getParent();

Review Comment:
   Yes, it is the naming issue in `getSnapshotsParentDir`.
   I renamed and changed the function to return `snapshotDir` path directly.
   I also added a comment explaining it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to