smengcl commented on PR #6014: URL: https://github.com/apache/ozone/pull/6014#issuecomment-2102763285
3 test failures remaining at this point, not including flaky ones: 1. [`TestRandomKeyGenerator.testKeyLargerThan2GB`](https://github.com/apache/ozone/actions/runs/8907392352/job/24479784720?pr=6014#step:6:2100) -- somehow key write always fails with this large 2.01 GB key in this test. It can be reproduced locally. If I change the key size to 0.01 GB it passes. I suspect this has something to do with client write buffer management as well. But haven't quite figured out why. 2. [`TestFailureHandlingByClient.testDatanodeExclusionWithMajorityCommit`](https://github.com/apache/ozone/actions/runs/8907392352/job/24479780977?pr=6014#step:6:2151) -- it fails because the test is expecting the datanode exclusion list to be populated with the datanode the test just shutdown. But it is not doing so because I modified `watchForCommit` to NOT actually do the Ratis request (remember? the goal of this PR is to 3. [`TestOzoneClientRetriesOnExceptions.testMaxRetriesByOzoneClient`](https://github.com/apache/ozone/actions/runs/8907392352/job/24479780977?pr=6014#step:6:2212) -- `AssertionFailedError: Expected java.io.IOException to be thrown, but nothing was thrown` looks to be the same type of issue as `TestCommitWatcher#testReleaseBuffersOnException` that I fixed already in 5c68ead09ca3c6235c998c338e9a64db957479fc. Should be an easy one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
