smengcl commented on PR #6014: URL: https://github.com/apache/ozone/pull/6014#issuecomment-2103609747
For 2: `XceiverClientRatis#watchForCommit` had this [logic](https://github.com/apache/ozone/blob/1057c62ec4fe5c68b6ffb3dc6108375b26092e3f/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java#L277-L278) where it initially attempts `ALL_COMMITTED`, but when it failed to do a 3-way commit, it falls back to `MAJORITY_COMMITTED`, which is where it adds the failed datanode to the list. `XceiverClientRatis#sendCommandAsync` might have to do exactly the same to keep the same behavior now that `watchForCommit` Ratis request is omitted. (Or is it worth keeping such behavior?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
