adoroszlai commented on PR #6664: URL: https://github.com/apache/ozone/pull/6664#issuecomment-2104137625
> Overall idea makes sense, but why do we do so much manual cache management? It seems like https://github.com/actions/setup-java and https://github.com/actions/setup-node can handle it for us. Are there extra requirements we have? 1. `setup-java` didn't have this feature when we first started using `cache`. Its simple config seems to correspond to our initial implementation with `cache`, so if this was available at the time, we could have chosen it. 2. `setup-java` does not give control over building a cache vs. only using it. Ozone has many concurrent checks which execute different Maven plugins. Basic checks like `checkstyle` can benefit from using the cache, but shouldn't build it, since they do not download many of the dependencies. So we rely on `cache/save` and `cache/restore`. 3. Building the cache from scratch in a separate workflow: - can produce a smaller cache, by not having to carry old dependencies forever, - helps avoid cache expiry, which may be a problem in forks with little activity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
