adoroszlai opened a new pull request, #6686:
URL: https://github.com/apache/ozone/pull/6686

   ## What changes were proposed in this pull request?
   
   This is the second attempt to fix intermittent failures caused by unreliable 
download from `nodejs.org`.
   
   Changes from previous attempt (#6664, which was reverted):
   
   1. Retry `curl` manually, because `--retry` does not seem to work if 
connection is closed during download 
([example](https://github.com/adoroszlai/ozone/actions/runs/9074924466/job/24934537902#step:6:153)).
   2. Also store NodeJS in its own cache to reduce the need to download from 
`nodejs.org`.
   3. Restored previous inline `mvn` command for populating the majority of the 
cache, only download of NodeJS is in separate shell script.  This reduces 
change against `master`, makes it easier to test download of NodeJS separately, 
and simplifies RC handling a bit.
   4. Avoid saving partial cache, because `cache/save` refuses to overwrite it 
on next run.  In this case CI will use earlier versions of the cache.
   
   https://issues.apache.org/jira/browse/HDDS-10273
   
   ## How was this patch tested?
   
   Successful run of `populate-cache`:
   https://github.com/adoroszlai/ozone/actions/runs/9110100989/job/25044393656
   
   Ozone build using cache from run above:
   - Linux: 
https://github.com/adoroszlai/ozone/actions/runs/9110734497/job/25046368135#step:6:2699
   - Mac: 
https://github.com/adoroszlai/ozone/actions/runs/9110734497/job/25047018432#step:7:2334
   
   `populate-cache` for same set of POM files (cache hit):
   https://github.com/adoroszlai/ozone/actions/runs/9111670296/job/25049278359
   
   `populate-cache` with failure (induced by adding `exit 1`) does not save 
cache:
   https://github.com/adoroszlai/ozone/actions/runs/9111209051/job/25047846517


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to