tanvipenumudy commented on code in PR #6439: URL: https://github.com/apache/ozone/pull/6439#discussion_r1603048063
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/metrics/SCMPerformanceMetrics.java: ########## @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.scm.container.placement.metrics; + +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.metrics2.MetricsCollector; +import org.apache.hadoop.metrics2.MetricsRecordBuilder; +import org.apache.hadoop.metrics2.MetricsSource; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MetricsRegistry; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; +import org.apache.hadoop.metrics2.lib.MutableRate; +import org.apache.hadoop.ozone.OzoneConsts; +import org.apache.hadoop.util.Time; + +/** + * Including SCM performance related metrics. + */ [email protected] +@Metrics(about = "SCM Performance Metrics", context = OzoneConsts.OZONE) +public final class SCMPerformanceMetrics implements MetricsSource { + private static final String SOURCE_NAME = + SCMPerformanceMetrics.class.getSimpleName(); + + private MetricsRegistry registry; + private static SCMPerformanceMetrics instance; + + @Metric private MutableCounterLong deleteKeyFailure; + @Metric private MutableCounterLong deleteKeySuccess; + @Metric(about = "Latency for deleteKey failure in nanoseconds") + private MutableRate deleteKeyFailureLatencyNs; + @Metric(about = "Latency for deleteKey success in nanoseconds") + private MutableRate deleteKeySuccessLatencyNs; + + public SCMPerformanceMetrics() { + this.registry = new MetricsRegistry(SOURCE_NAME); + } + + public static SCMPerformanceMetrics create() { + if (instance != null) { + return instance; + } + MetricsSystem ms = DefaultMetricsSystem.instance(); + instance = ms.register(SOURCE_NAME, "SCM Performance Metrics", + new SCMPerformanceMetrics()); + return instance; + } + + public void unRegister() { Review Comment: We aren't using the `unRegister()` method anywhere. Please call this under the `StorageContainerManager#stop` ([link](https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L1640) to code snippet) for unregistering the metrics source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
