tanvipenumudy commented on code in PR #6439:
URL: https://github.com/apache/ozone/pull/6439#discussion_r1603128351
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -261,26 +264,33 @@ public List<DeleteBlockGroupResult> deleteKeyBlocks(
List<DeleteBlockGroupResult> results = new ArrayList<>();
Map<String, String> auditMap = Maps.newHashMap();
ScmBlockLocationProtocolProtos.DeleteScmBlockResult.Result resultCode;
+ perfMetrics = scm.getPerfMetrics();
Review Comment:
Could you please initialize `SCMPerformanceMetrics` at a common place so it
is accessible to all methods, instead of doing so under this specific method,
allowing for the addition of metrics in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
