ChenSammi commented on code in PR #6690:
URL: https://github.com/apache/ozone/pull/6690#discussion_r1609191826
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChunkBufferImplWithByteBuffer.java:
##########
@@ -163,4 +175,12 @@ public String toString() {
return getClass().getSimpleName() + ":limit=" + buffer.limit()
+ "@" + Integer.toHexString(hashCode());
}
+
+ @Override
+ protected void finalize() throws Throwable {
Review Comment:
ChunkBuffer#close() has been tried before use finalize(), but it's not get
called when the buffer is auto reclaimed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]