ChenSammi commented on PR #6690: URL: https://github.com/apache/ozone/pull/6690#issuecomment-2128427394
> @ChenSammi if I understand correctly, Datanode does not free up the mmap handles as aggressively as we would like. Thus, we need to introduce this change. I would recommend the following choices over adding complexity. > > 1. Can we bump up the limit in the OS, the Datanode should stable state to a certain upper bound based on GC frequency and concurrency setting. > > 2. We can revert to non mmap handling if we hit the limit. > > > I agree with @duongkame the correctly solution might be to implement a new read API using netty and using the better abstractions it offers to manage direct buffers and NIO capabilities. @kerneltime , the proposed solution is exactly putting a upper bound limit and fallback to non mmap buffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
