smengcl commented on code in PR #6014:
URL: https://github.com/apache/ozone/pull/6014#discussion_r1628435332
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/ContainerProtocolCalls.java:
##########
@@ -291,7 +292,10 @@ public static XceiverClientReply
putBlockAsync(XceiverClientSpi xceiverClient,
throws IOException, InterruptedException, ExecutionException {
final ContainerCommandRequestProto request = getPutBlockRequest(
xceiverClient.getPipeline(), containerBlockData, eof, tokenString);
- return xceiverClient.sendCommandAsync(request);
+ // TODO: Make only putBlock triggered from hsync ALL_COMMITTED.
+ // While keeping the ones triggered from write() and others at MAJORITY
+ // and call regular watchForCommit in order to reduce latency for
write()s.
Review Comment:
Yes this is considered. Currently a TODO just down below in
`writeChunkAsync()`.
When PutBlock is piggybacked in WriteChunk, `putBlockAsync()` won't be
called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
