adoroszlai commented on PR #6742: URL: https://github.com/apache/ozone/pull/6742#issuecomment-2161293401
Thanks @ArafatKhan2198 for updating the patch. > **ReconPipelineReportHandler:** > > * No changes were made. The existing early check for pipeline existence and fetching from SCM if it doesn't exist remains intact to ensure the necessary pipeline information is retrieved before attempting to add it. It's not a big deal, but maybe this one could be changed to make logging conditional: https://github.com/apache/ozone/blob/e45d5f208c44519dfe9e97e621ee668afba1f6f4/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconPipelineReportHandler.java#L86-L88 similar to: https://github.com/apache/ozone/blob/0d2faa403125186d8bf805decebd9aa8e53ed6b6/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconContainerManager.java#L233-L235 just in case some other process added the same pipeline in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
