hemantk-12 commented on code in PR #6812:
URL: https://github.com/apache/ozone/pull/6812#discussion_r1638995283
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/ClientVersion.java:
##########
@@ -28,7 +28,7 @@
/**
* Versioning for protocol clients.
*/
-public enum ClientVersion implements ComponentVersion {
+public enum ClientVersion implements ComponentVersion,
Comparable<ClientVersion> {
Review Comment:
Is it intentional change?
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/ContainerProtocolCalls.java:
##########
@@ -97,6 +98,28 @@ public final class ContainerProtocolCalls {
private ContainerProtocolCalls() {
}
+ /**
+ * Creates a ContainerCommandRequestProto with version set.
+ */
+ public static ContainerCommandRequestProto.Builder
getContainerCommandRequestProtoBuilder(int version) {
+ return getContainerCommandRequestProtoBuilder(null, version);
+ }
+
+ public static ContainerCommandRequestProto.Builder
getContainerCommandRequestProtoBuilder() {
+ return
getContainerCommandRequestProtoBuilder(ClientVersion.CURRENT.toProtoValue());
Review Comment:
nit:
```suggestion
return getContainerCommandRequestProtoBuilder(null,
ClientVersion.CURRENT.toProtoValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
