swamirishi commented on PR #6812: URL: https://github.com/apache/ozone/pull/6812#issuecomment-2167029414
> Thanks @swamirishi for the patch. In general, change looks good to me. Left a comment about one change in ClientVersion. > > nit: I don't think it is a good idea to provide a helper function on top of builder. I guess you have done it this way to make the version mandatory field and `ContainerCommandRequestProto.newBuilder()` is generated by protobuf. Yeah I wanted to mandate client versions are being set to the latest value on all the request. I don't think there is a programatic way of doing this in protobuf. From what I know we can only set a constant value in proto file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
