dombizita commented on PR #6860:
URL: https://github.com/apache/ozone/pull/6860#issuecomment-2220717265
With the recent changes I added, when we call the `entrySet()` method in the
`DelegatingProperties` class it throws UnsupportedOperationException. The goal
with this is that we can't get values from its Properties object without the
compliance check. I thought that the entrySet is only used in the `iterator()`
method (which I handle in the DelegatingProperties class), but from the
failures we see that in the Configuration class we use it elsewhere too, e.g.
in the `getValByRegex()` method.
```
Error: Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
0.654 s <<< FAILURE! - in org.apache.hadoop.hdds.TestHddsUtils
Error:
org.apache.hadoop.hdds.TestHddsUtils.testRedactSensitivePropsForLogging Time
elapsed: 0.015 s <<< ERROR!
java.lang.UnsupportedOperationException: Entryset is not available in
DelegatingProperties
at
org.apache.hadoop.hdds.conf.DelegatingProperties.entrySet(DelegatingProperties.java:165)
at
org.apache.hadoop.conf.Configuration.getValByRegex(Configuration.java:3935)
at
org.apache.hadoop.hdds.conf.OzoneConfiguration.getOzoneProperties(OzoneConfiguration.java:281)
at
org.apache.hadoop.hdds.HddsUtils.processForLogging(HddsUtils.java:792)
at
org.apache.hadoop.hdds.TestHddsUtils.testRedactSensitivePropsForLogging(TestHddsUtils.java:256)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
```
I'll look into this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
