dombizita commented on PR #6860: URL: https://github.com/apache/ozone/pull/6860#issuecomment-2221674966
I checked where do we use the entrySet() method in the Configuration class on its Properties (I didn't find usages in other configuration related classes). These are the occurrences: - `iterator()` - it's handled as we overwrite the iterator() method in both the OzoneConfiguration and the LegacyHadoopConfigurationSource classes - `overlay()` - we are just putting everything form one Properties object to another Properties object. This shouldn't cause problems, as later when we read from them we will do the compliance check - `dumpConfiguration()` - it doesn't call the `getValue()` on the entrySet element, shouldn't be a problem - `write()` - this will call the `item.getValue()`, but it will only write it out to a DataOutput, so once we read from this, we will do the compliance check - `getValByRegex()` - we are calling the `item.getValue()`, bust we are only checking if it's a String, we don't do anything else with it. Based on this, we can say that the only occurrence where we are actually doing something with a configuration value that we got through a props.entrySet() call is handled. But because of the other usages I can't throw an UnsupportedOperationException. I update my patch, so I can see a better CI run, based on the ongoing review I can change it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
