[
https://issues.apache.org/jira/browse/HDDS-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-11139:
----------------------------------
Labels: pull-request-available (was: )
> Avoid unnecessary object creation in OM request validator
> ---------------------------------------------------------
>
> Key: HDDS-11139
> URL: https://issues.apache.org/jira/browse/HDDS-11139
> Project: Apache Ozone
> Issue Type: Improvement
> Components: Ozone Manager
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Labels: pull-request-available
>
> Conversion is unnecessary:
> {code:title=https://github.com/apache/ozone/blob/975a8d85a343a3b7a971b6798493280684456136/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java#L68}
> OMRequest validatedRequest = request.toBuilder().build();
> {code}
> Default value can be created lazily (only if not found in map):
> {code:title=https://github.com/apache/ozone/blob/975a8d85a343a3b7a971b6798493280684456136/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/ValidatorRegistry.java#L181-L188}
> private <K, V> V getAndInitialize(K key, V defaultValue, Map<K, V> from) {
> V inMapValue = from.get(key);
> if (inMapValue == null || !from.containsKey(key)) {
> from.put(key, defaultValue);
> return defaultValue;
> }
> return inMapValue;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
