szetszwo commented on code in PR #6968:
URL: https://github.com/apache/ozone/pull/6968#discussion_r1688295794


##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -150,6 +153,7 @@ public class BlockOutputStream extends OutputStream {
   private boolean allowPutBlockPiggybacking;
 
   private CompletableFuture<Void> lastFlushFuture;
+  private Set<CompletableFuture<Void>> allFlushFutures = 
Collections.newSetFromMap(new ConcurrentHashMap<>());

Review Comment:
   How about changing `Set <..> allFlushFutures` to `CompletableFuture<Void> 
allFlushFuture`?  Then, we don't have to take care about removing the futures.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to