smengcl commented on code in PR #6968:
URL: https://github.com/apache/ozone/pull/6968#discussion_r1688781075
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -640,6 +655,13 @@ private void handleFlushInternal(boolean close)
}
LOG.debug("Flush done.");
}
+
+ if (close) {
+ // When closing, must wait for all flush futures to complete.
+ for (CompletableFuture<Void> flushFuture : allPendingFlushFutures) {
+ flushFuture.get();
+ }
+ }
Review Comment:
> Isn't it supposed to be serialized on Raft server on datanode end?
Yes. Tho the client side closes the connection in another async stage so it
will not guarantee the order there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
