errose28 commented on code in PR #6864:
URL: https://github.com/apache/ozone/pull/6864#discussion_r1688352539
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java:
##########
@@ -44,12 +46,15 @@ public class ContainerChecksumTreeManager {
// Used to coordinate reads and writes to each container's checksum file.
// Each container ID is mapped to a stripe.
private final Striped<ReadWriteLock> fileLock;
+ private final ContainerMerkleTreeMetrics metrics;
/**
* Creates one instance that should be used to coordinate all container
checksum info within a datanode.
*/
public ContainerChecksumTreeManager(DatanodeConfiguration dnConf) {
fileLock =
SimpleStriped.readWriteLock(dnConf.getContainerChecksumLockStripes(), true);
+ // TODO: TO unregister metrics on stop.
Review Comment:
I made a note of this
[here](https://github.com/apache/ozone/pull/6875/files#r1688351623). This PR
connects the manager to `OzoneContainer` where we can unregister the metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
