errose28 commented on code in PR #6864:
URL: https://github.com/apache/ozone/pull/6864#discussion_r1688362907
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java:
##########
@@ -92,28 +104,26 @@ public void markBlocksAsDeleted(KeyValueContainerData
data, SortedSet<Long> dele
.clearDeletedBlocks()
.addAllDeletedBlocks(sortedDeletedBlockIDs)
.build();
- write(data, checksumInfoBuilder.build());
+ captureLatencyNs(metrics.getUpdateContainerMerkleTreeLatencyNS(),
+ () -> write(data, checksumInfoBuilder.build()));
Review Comment:
Can we move the read and write metrics inside the read and write methods so
we don't need to duplicate this code every time they are called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
