devabhishekpal commented on code in PR #6977:
URL: https://github.com/apache/ozone/pull/6977#discussion_r1694106409
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -81,6 +90,18 @@
$scope.totalItems = nodeStatusCopy.length;
$scope.lastIndex = Math.ceil(nodeStatusCopy.length /
$scope.RecordsToDisplay);
$scope.nodeStatus = nodeStatusCopy.slice(0,
$scope.RecordsToDisplay);
+
+ ctrl.nodemanagermetrics.NodeStatistics.map(({ key, value
}) => {
Review Comment:
While using a `.map()` will give us the same result, but it will also return
an array (empty in this case) which we are ignoring as the value is not being
assigned.
This might not be affecting the performance or anything, as it is a minor
operation, but I would suggest to use `.forEach` in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
