devabhishekpal commented on code in PR #6977:
URL: https://github.com/apache/ozone/pull/6977#discussion_r1694664405
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm.js:
##########
@@ -81,6 +91,18 @@
$scope.totalItems = nodeStatusCopy.length;
$scope.lastIndex = Math.ceil(nodeStatusCopy.length /
$scope.RecordsToDisplay);
$scope.nodeStatus = nodeStatusCopy.slice(0,
$scope.RecordsToDisplay);
+
+
ctrl.nodemanagermetrics.NodeStatistics.forEach(function(obj) {
Review Comment:
Just fyi, can de-structure this as well like you did for map().
Since obj = { key: abc, value: xyz }, we can destructure it as:
{key, value} = obj
So the function could also be written as:
```
ctrl.nodemanagermetrics.NodeStatistics.forEach(({key, value}) => {
....
});
```
But your current change is good as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
