adoroszlai commented on code in PR #6497:
URL: https://github.com/apache/ozone/pull/6497#discussion_r1720912100
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java:
##########
@@ -145,10 +145,11 @@ List<ContainerWithPipeline>
getExistContainerWithPipelinesInBatch(
* Usually the count will be replace with a very big
* value instead of being unlimited in case the db is very big)
*
- * @return a list of container.
+ * @return a list of containers capped by max count allowed
+ * in "hdds.container.list.max.count" and total number of containers.
* @throws IOException
*/
- List<ContainerInfo> listContainer(long startContainerID,
+ Pair<List<ContainerInfo>, Long> listContainer(long startContainerID,
Review Comment:
This kind of change doesn't seem to be backwards compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
