sumitagrawl commented on PR #7181: URL: https://github.com/apache/ozone/pull/7181#issuecomment-2354742105
> Hi @sarvekshayr can we do this with pagination as described in [HDDS-10687](https://issues.apache.org/jira/browse/HDDS-10687)? From what I can tell we don't need a new SCM API to do this since `SCMClientProtocolServer#listContainer` already takes an offset and count. We just need the client to transparently paginate through calls to this API with fixed size batches when the user passes `--all`. Already listContainer have option for start container (i.e. -s). So pagination for cli can use below way (already present). Lets, count=10 as used, Call 1: -s = 0 (or if not provided, will return from first container) ==> 1-10 containers Call 2: -s=11, it will return next matching containers (10 containers), like from 11-20 OR, if 11-13 is not present, will return 14-23 containers. So nothing more is required for pagination and can follow above approach. Similar case is implemented in various UI pagination passing starting container IDs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
